Re: [Qemu-devel] [PATCH v4 0/1] qemu-ga: add guest-get-osinfo command

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PATCH v4 0/1] qemu-ga: add guest-get-osinfo command
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
50aaba2 qemu-ga: add guest-get-osinfo command

=== OUTPUT BEGIN ===
Checking PATCH 1/1: qemu-ga: add guest-get-osinfo command...
ERROR: "foo* bar" should be "foo *bar"
#58: FILE: qga/commands-posix.c:2583:
+static GHashTable* ga_parse_osrelease(const char *fname)

ERROR: "foo* bar" should be "foo *bar"
#62: FILE: qga/commands-posix.c:2587:
+    GDataInputStream* dis = NULL;

ERROR: space required before the open parenthesis '('
#94: FILE: qga/commands-posix.c:2619:
+        } else if((length == 0) || (line[0] == '#')) {

ERROR: switch and case should be at the same indent
#112: FILE: qga/commands-posix.c:2637:
+                    switch(*(p+1)) {
+                        case '\'':
+                        case '"':
+                        case '$':
+                        case '`':
[...]
+                        default:

ERROR: spaces required around that '+' (ctx:VxV)
#112: FILE: qga/commands-posix.c:2637:
+                    switch(*(p+1)) {
                               ^

ERROR: space required before the open parenthesis '('
#112: FILE: qga/commands-posix.c:2637:
+                    switch(*(p+1)) {

ERROR: spaces required around that '+' (ctx:VxV)
#117: FILE: qga/commands-posix.c:2642:
+                            memmove(p, p+1, strlen(p+1));
                                         ^

ERROR: spaces required around that '+' (ctx:VxV)
#117: FILE: qga/commands-posix.c:2642:
+                            memmove(p, p+1, strlen(p+1));
                                                     ^

ERROR: trailing whitespace
#418: FILE: qga/qapi-schema.json:1151:
+# $

ERROR: trailing whitespace
#421: FILE: qga/qapi-schema.json:1154:
+# $

total: 10 errors, 0 warnings, 411 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden