[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/2] Make info migrate output consistent
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/2] Make info migrate output consistent |
Date: |
Wed, 7 Jun 2017 19:37:15 +0800 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Wed, Jun 07, 2017 at 12:58:08PM +0200, Juan Quintela wrote:
> Hi
>
> Changes for v2:
> - patches 1 & 2 in previous pull requset
> - create function populate_disk_info (dave suggestion)
>
> Please, review.
>
> Thanks, Juan.
>
> [v1]
> This series make the output of info migrate be printed in a single
> place for the states ACTIVE, CANCELLING and POSTCOPY_ACTIVE.
>
> The code was duplicated, just use the same code. Once done that, fix
> the inconsistences that were not needed.
I feel that putting cpu throttling info into populate_ram_info() is
still slightly weird, but hmm it's okay and that's trivial.
Reviewed-by: Peter Xu <address@hidden>
Thanks,
--
Peter Xu