[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] configure: split c and cxx extra flags
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v2] configure: split c and cxx extra flags |
Date: |
Wed, 7 Jun 2017 15:30:41 +0100 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Tue, Jun 06, 2017 at 02:07:47PM +0100, Bruno Dominguez wrote:
> There was no possibility to add specific cxx flags using the configure
> file. So A new entrance has been created to support it.
>
> Duplication of information in configure and rules.mak. Taking
> QEMU_CFLAGS and add them to QEMU_CXXFLAGS, now the value of
> QEMU_CXXFLAGS is stored in config-host.mak, so there is no need for
> it.
>
> The makefile for libvixl was adding flags for QEMU_CXXFLAGS in
> QEMU_CFLAGS because of the addition in rules.mak. That was removed, so
> adding them where it should be.
>
> Signed-off-by: Bruno Dominguez <address@hidden>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
> ---
> v2:
> * Matching --extra-cxxflags description with --cxx
> * Removing some extra spaces indicated by checkpatch script
> * Fixed patch format
> ---
> configure | 74
> +++++++++++++++++++++++++--------------------
> disas/libvixl/Makefile.objs | 2 +-
> rules.mak | 3 --
> 3 files changed, 43 insertions(+), 36 deletions(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
signature.asc
Description: PGP signature