Re: [Qemu-devel] [PATCH v8 07/11] migration: add bitmap for copied page

[Alexey Perevalov]

On 06/07/2017 03:56 PM, Juan Quintela wrote:
> Alexey Perevalov <address@hidden> wrote:
>
> > +static unsigned long get_copiedmap_size(RAMBlock *rb)
> > +{
> > +    unsigned long pages;
> > +    pages = rb->max_length >> find_first_bit((unsigned long *)&rb->page_size,
> > +                                             sizeof(rb->page_size));
> > +    return pages;
> Are you sure that you want this and not:
>
> pages = rb->max_length >> TARGET_PAGE_BITS?
I just wish to optimize size of bitmap,
> Otherwise, in some architectures/configurations you can end with a
> bitmap size that is different of the migration bitmap size.
looks like, yes, that solution is for le only, so I feel luck
of converting to le, here.

>

--
Best regards,
Alexey Perevalov