|
From: | Juan Quintela |
Subject: | Re: [Qemu-devel] [RFC PATCH 2/3] vmstate: error hint for failed equal checks part 2 |
Date: | Wed, 07 Jun 2017 18:35:51 +0200 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Halil Pasic <address@hidden> wrote: > Verbose error reporting for the _EQUAL family. Modify the standard _EQUAL > so the hint states the assertion probably failed due to a bug. Introduce > _EQUAL_HINT for specifying a context specific hint. > > Signed-off-by: Halil Pasic <address@hidden> > --- > Keeping this separate for now because we may want something different > here. E.g. no new macros and adding an extra NULL parameter for all > pre-existing _EQUAL usages. I think that the best thing is to just add the HINT always. I checked and there are only 25 uses of VMSTATE_*_EQUAL. I agree with dave that adding a NULL there, and make they work is a better strategy. We are adding 8 new macros so we don't have to change 25 callers? Later, Juan.
[Prev in Thread] | Current Thread | [Next in Thread] |