[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 3/3] s390x/css: add hint for devno missmatch
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [RFC PATCH 3/3] s390x/css: add hint for devno missmatch |
Date: |
Wed, 07 Jun 2017 18:37:02 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
"Dr. David Alan Gilbert" <address@hidden> wrote:
> * Halil Pasic (address@hidden) wrote:
>> This one has to be fixed up to 's390x: vmstatify config migration for
>> virtio-ccw' provided we want to achieve the same as 's390x/css: catch
>> section mismatch on load' does.
>>
>> Signed-off-by: Halil Pasic <address@hidden>
>> ---
>>
>> This is on tom of 's390x: vmstatify config migration for virtio-ccw'
> p
>> which ain't on top of 's390x/css: catch section mismatch on load' but on
>> top of master. I kind of have a circular dependency here. This is why
>> the series is RFC.
>>
>> Wanted to provide an usage example. Faked 'Re: ' so patchew does not
>> try to apply this on top of current master.
>> ---
>> hw/s390x/css.c | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/hw/s390x/css.c b/hw/s390x/css.c
>> index 348129e1b2..de277d6a3d 100644
>> --- a/hw/s390x/css.c
>> +++ b/hw/s390x/css.c
>> @@ -134,6 +134,10 @@ static const VMStateDescription vmstate_sense_id = {
>> static int subch_dev_post_load(void *opaque, int version_id);
>> static void subch_dev_pre_save(void *opaque);
>>
>> +const char err_hint_devno[] = "Devno mismatch, tried to load wrong section!"
>> + " Likely reason: some sequences of plug and unplug can break"
>> + " migration for machine versions prior to 2.7 (known design flaw).";
>> +
>
> That's ok, but I suggest:
> * 'bug' rather than 'design flaw' - it sounds a bit less scary to
> endusers.
If we are being politically correct:
(known limitation)?
O:-)
Reviewed-by: Juan Quintela <address@hidden>
Later, Juan.
- Re: [Qemu-devel] [RFC PATCH 1/3] vmstate: error hint for failed equal checks, (continued)
- Re: [Qemu-devel] [RFC PATCH 1/3] vmstate: error hint for failed equal checks, Halil Pasic, 2017/06/08
- Re: [Qemu-devel] [RFC PATCH 1/3] vmstate: error hint for failed equal checks, Halil Pasic, 2017/06/14
- Re: [Qemu-devel] [RFC PATCH 1/3] vmstate: error hint for failed equal checks, Dr. David Alan Gilbert, 2017/06/22
- Re: [Qemu-devel] [RFC PATCH 1/3] vmstate: error hint for failed equal checks, Halil Pasic, 2017/06/22
- Re: [Qemu-devel] [RFC PATCH 1/3] vmstate: error hint for failed equal checks, Dr. David Alan Gilbert, 2017/06/22
- Re: [Qemu-devel] [RFC PATCH 1/3] vmstate: error hint for failed equal checks, Eric Blake, 2017/06/29
Re: [Qemu-devel] [RFC PATCH 3/3] s390x/css: add hint for devno missmatch, Halil Pasic, 2017/06/06