Re: [Qemu-devel] [PATCH 0/5] Code cleanups with Coccinelle

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH 0/5] Code cleanups with Coccinelle
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
ff94aae coccinelle: prefer glib g_new/g_renew macros
735e634 Replace g_malloc()+memcpy() with g_memdup()
d75f7c3 arch: introduce ELF_NOTE_SIZE macro
2dba3de coccinelle: use DIV_ROUND_UP
b38b048 coccinelle: replace code with ROUND_UP macro

=== OUTPUT BEGIN ===
Checking PATCH 1/5: coccinelle: replace code with ROUND_UP macro...
Checking PATCH 2/5: coccinelle: use DIV_ROUND_UP...
ERROR: code indent should never use tabs
#65: FILE: disas/ia64.c:10159:
+^I^I      next_op = op_pointer + (DIV_ROUND_UP(oplen, 8));$

ERROR: code indent should never use tabs
#73: FILE: disas/ia64.c:10166:
+^I^I  next_op = op_pointer + (DIV_ROUND_UP(oplen, 8));$

ERROR: code indent should never use tabs
#225: FILE: libdecnumber/decNumber.c:5024:
+      zoff=DIV_ROUND_UP(iacc, 8);^I      /* items to offset by */$

ERROR: spaces required around that '=' (ctx:VxV)
#225: FILE: libdecnumber/decNumber.c:5024:
+      zoff=DIV_ROUND_UP(iacc, 8);            /* items to offset by */
           ^

total: 4 errors, 0 warnings, 240 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/5: arch: introduce ELF_NOTE_SIZE macro...
Checking PATCH 4/5: Replace g_malloc()+memcpy() with g_memdup()...
Checking PATCH 5/5: coccinelle: prefer glib g_new/g_renew macros...
ERROR: code indent should never use tabs
#801: FILE: hw/dma/etraxfs_dma.c:776:
+^Ictrl->channels = g_new0(typeof(ctrl->channels[0]), nr_channels);$

ERROR: code indent should never use tabs
#2937: FILE: util/envlist.c:221:
+^Ipenv = env = g_new(char *, envlist->el_count + 1);$

total: 2 errors, 0 warnings, 2034 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden