qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RFC] block: add throttle block filter driver


From: Manos Pitsidianakis
Subject: Re: [Qemu-devel] [PATCH RFC] block: add throttle block filter driver
Date: Thu, 8 Jun 2017 01:08:56 +0300
User-agent: NeoMutt/20170113 (1.7.2)

On Wed, Jun 07, 2017 at 04:38:43PM -0500, Eric Blake wrote:
On 06/07/2017 11:06 AM, Manos Pitsidianakis wrote:
On Wed, Jun 07, 2017 at 10:40:08AM -0500, Eric Blake wrote:
On 06/07/2017 08:06 AM, Manos Pitsidianakis wrote:
This is part of my work for my GSOC project this summer.

I am not sure if the count parameter in  bdrv_co_pwrite_zeros and
bdrv_co_pdiscard refers to sectors or bytes.

Both refer to byte counts.  (We're trying to get rid of as many
sector-based interfaces as possible, but it's slow going to make sure
the conversions are still accurate).

I see. Would changing the names in the BlockDriverState function
signatures to reflect that be okay?

What names need changing?

I meant, change "int count" to "int bytes" in the bdrv_co_pwrite_zeros and bdrv_co_pdiscard signatures inside struct BlockDriverState.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]