[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v3 06/23] block: access quiesce_counter with atomic o
From: |
Fam Zheng |
Subject: |
[Qemu-devel] [PULL v3 06/23] block: access quiesce_counter with atomic ops |
Date: |
Thu, 8 Jun 2017 19:56:26 +0800 |
From: Paolo Bonzini <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Fam Zheng <address@hidden>
---
block/io.c | 4 ++--
include/block/block_int.h | 1 +
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/block/io.c b/block/io.c
index 98c690f..70643df 100644
--- a/block/io.c
+++ b/block/io.c
@@ -241,7 +241,7 @@ void bdrv_drained_begin(BlockDriverState *bs)
return;
}
- if (!bs->quiesce_counter++) {
+ if (atomic_fetch_inc(&bs->quiesce_counter) == 0) {
aio_disable_external(bdrv_get_aio_context(bs));
bdrv_parent_drained_begin(bs);
}
@@ -252,7 +252,7 @@ void bdrv_drained_begin(BlockDriverState *bs)
void bdrv_drained_end(BlockDriverState *bs)
{
assert(bs->quiesce_counter > 0);
- if (--bs->quiesce_counter > 0) {
+ if (atomic_fetch_dec(&bs->quiesce_counter) > 1) {
return;
}
diff --git a/include/block/block_int.h b/include/block/block_int.h
index 49f2ebb..1824e0e 100644
--- a/include/block/block_int.h
+++ b/include/block/block_int.h
@@ -637,6 +637,7 @@ struct BlockDriverState {
/* do we need to tell the quest if we have a volatile write cache? */
int enable_write_cache;
+ /* Accessed with atomic ops. */
int quiesce_counter;
};
--
2.9.4
- [Qemu-devel] [PULL v3 00/23] Docker and block patches, Fam Zheng, 2017/06/08
- [Qemu-devel] [PULL v3 02/23] docker: Add bzip2 and hostname to fedora image, Fam Zheng, 2017/06/08
- [Qemu-devel] [PULL v3 01/23] docker: Run tests with current user, Fam Zheng, 2017/06/08
- [Qemu-devel] [PULL v3 03/23] docker: Add libaio to fedora image, Fam Zheng, 2017/06/08
- [Qemu-devel] [PULL v3 04/23] docker: Add flex and bison to centos6 image, Fam Zheng, 2017/06/08
- [Qemu-devel] [PULL v3 05/23] block: access copy_on_read with atomic ops, Fam Zheng, 2017/06/08
- [Qemu-devel] [PULL v3 07/23] block: access io_limits_disabled with atomic ops, Fam Zheng, 2017/06/08
- [Qemu-devel] [PULL v3 06/23] block: access quiesce_counter with atomic ops,
Fam Zheng <=
- [Qemu-devel] [PULL v3 08/23] block: access serialising_in_flight with atomic ops, Fam Zheng, 2017/06/08
- [Qemu-devel] [PULL v3 09/23] block: access wakeup with atomic ops, Fam Zheng, 2017/06/08
- [Qemu-devel] [PULL v3 11/23] throttle-groups: only start one coroutine from drained_begin, Fam Zheng, 2017/06/08
- [Qemu-devel] [PULL v3 12/23] throttle-groups: do not use qemu_co_enter_next, Fam Zheng, 2017/06/08
- [Qemu-devel] [PULL v3 13/23] throttle-groups: protect throttled requests with a CoMutex, Fam Zheng, 2017/06/08
- [Qemu-devel] [PULL v3 10/23] block: access io_plugged with atomic ops, Fam Zheng, 2017/06/08
- [Qemu-devel] [PULL v3 14/23] util: add stats64 module, Fam Zheng, 2017/06/08
- [Qemu-devel] [PULL v3 15/23] block: use Stat64 for wr_highest_offset, Fam Zheng, 2017/06/08
- [Qemu-devel] [PULL v3 16/23] block: access write_gen with atomics, Fam Zheng, 2017/06/08
- [Qemu-devel] [PULL v3 19/23] migration/block: reset dirty bitmap before reading, Fam Zheng, 2017/06/08