Re: [Qemu-devel] [PATCH 2/6] migration: move global_state.optional out

[Juan Quintela]

Peter Xu <address@hidden> wrote:
> On Thu, Jun 08, 2017 at 01:12:29PM +0200, Juan Quintela wrote:
>> Peter Xu <address@hidden> wrote:
>> > On Wed, Jun 07, 2017 at 07:42:57PM +0200, Juan Quintela wrote:

...
>> 
>> Yeap.  I *thought* that there was a way to test/set thing
>> programatically also so I didn't have to create/export that functions.
>> My ideal world would be that there were something like that
>> 
>> qemu_opt_get_bool(migration_opts, "store_global_state", true);
>> 
>> so I only have to export migration_opts (or whatever), and just set/read
>> values from places like xen_init.  Im my ideal world, if I have to
>> create a new "property", I don't want to have to export a function to
>> set/read it.  For instance, the case of xen_init().  We haven't been
>> able to remove global_state_set_optional() because they don't know about
>> properties.
>> 
>> I still love the patches are they are.  Boing able to set things from
>> the command line makes things so much better/easier O:-)
>
> Oh, looks like what we need to do is just export
> register_compat_prop(), then xen_init() can use it.
>
> I'll try that tomorrow. :)

Thanks, Juan.