qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/5] Error handling cleanup and fixes


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 0/5] Error handling cleanup and fixes
Date: Thu, 8 Jun 2017 10:18:04 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0

On 06/08/2017 08:39 AM, Eduardo Habkost wrote:
> This series fixes and simplifies some of the existing code that
> assigns to *errp directly.
> 
> Eduardo Habkost (5):
>   xilinx: Fix error handling
>   block: Don't try to set *errp directly
>   websock: Don't try to set *errp directly
>   migration: Don't try to set *errp directly
>   vnc: No need for Error** parameter at vnc_client_io_error()

For 1-4:
Reviewed-by: Eric Blake <address@hidden>

I'm not sure about 5

> 
>  ui/vnc.h                |  2 +-
>  block.c                 |  8 +++-----
>  hw/dma/xilinx_axidma.c  |  4 +---
>  hw/net/xilinx_axienet.c |  4 +---
>  io/channel-websock.c    |  4 ++--
>  migration/migration.c   |  2 +-
>  ui/vnc.c                | 13 +++++--------
>  7 files changed, 14 insertions(+), 23 deletions(-)
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]