qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH 3/3] tcg/aarch64: Remove code buffer size li


From: Richard Henderson
Subject: Re: [Qemu-devel] [RFC PATCH 3/3] tcg/aarch64: Remove code buffer size limitation
Date: Thu, 8 Jun 2017 09:58:19 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0

On 06/07/2017 03:52 PM, Pranith Kumar wrote:
This enables indirect jump on aarch64 hosts. Tested by booting an x86 guest on 
aarch64 host.

This patch is doing too many things.

One patch should be the switch to indirect chaining (which should also squash in the 2/3 patch, otherwise tcg_out_insn_3305 is unused and therefore provokes a Werror).

Second, you should consider merely softening the code buffer size limitation to 2GB. At that point, we still use just ADRP+ADD to form the return address for exit_tb.

Third, if you want to go beyond 2GB to no limit at all, then we need to consider reserving a register to contain the return address back to the epilogue.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]