[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Add manpage for QEMU Backup Tool
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH] Add manpage for QEMU Backup Tool |
Date: |
Fri, 9 Jun 2017 09:33:53 +0100 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Thu, Jun 08, 2017 at 07:29:55PM -0700, address@hidden wrote:
> === OUTPUT BEGIN ===
> Checking PATCH 1/1: Add manpage for QEMU Backup Tool...
> ERROR: trailing whitespace
> #28: FILE: contrib/backup/qemu-backup.texi:1:
> + $
Hi Ishani,
In case you are wondering about these errors - please send a new
revision (v2) of this patch with the whitespace issues fixed.
Here are a few Vim tips but I'm sure you can do the same in Emacs or
other editors:
1. Add the following to your .vimrc to highlight trailing whitespace:
hi WhiteSpaceEOL ctermbg=red guibg=red
au InsertEnter * match WhiteSpaceEOL /\s\+\%#\@<!$/
au InsertLeave * match WhiteSpaceEOL /\s\+$/
2. Use this search-and-replace command to get rid of trailing
whitespace:
:%s/\s\+$//g
I recommend running scripts/checkpatch.pl yourself before submitting
patches. You can do it automatically from a git hook (see githooks(5))
by following the instructions here:
http://blog.vmsplice.net/2011/03/how-to-automatically-run-checkpatchpl.html
Stefan
signature.asc
Description: PGP signature