Re: [Qemu-devel] [PATCH 1/3] commit: Fix completion with extra reference

[Eric Blake]

On 06/09/2017 06:50 AM, Kevin Wolf wrote:
> commit_complete() can't assume that after its block_job_completed() the
> job is actually immediately freed; someone else may still be holding
> references. In this case, the op blockers on the intermediate nodes make
> the graph reconfiguration in the completion code fail.
> 
> Call block_job_remove_all_bdrv() manually so that we know for sure that
> any blockers on intermediate nodes are given up.
> 
> Cc: address@hidden
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block/commit.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature