[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] translate-all: consolidate tb init in tb_gen_code
From: |
Emilio G. Cota |
Subject: |
[Qemu-devel] [PATCH] translate-all: consolidate tb init in tb_gen_code |
Date: |
Fri, 9 Jun 2017 15:55:22 -0400 |
We are partially initializing tb in tb_alloc. Instead, fully
initialize it in tb_gen_code, which is tb_alloc's only caller.
This saves an unnecessary write to tb->cflags.
Signed-off-by: Emilio G. Cota <address@hidden>
---
translate-all.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/translate-all.c b/translate-all.c
index 966747a..d4f364d 100644
--- a/translate-all.c
+++ b/translate-all.c
@@ -841,9 +841,6 @@ static TranslationBlock *tb_alloc(target_ulong pc)
ctx->tbs = g_renew(TranslationBlock *, ctx->tbs, ctx->tbs_size);
}
ctx->tbs[ctx->nb_tbs++] = tb;
- tb->pc = pc;
- tb->cflags = 0;
- tb->invalid = false;
return tb;
}
@@ -1287,9 +1284,11 @@ TranslationBlock *tb_gen_code(CPUState *cpu,
gen_code_buf = tcg_ctx.code_gen_ptr;
tb->tc_ptr = gen_code_buf;
+ tb->pc = pc;
tb->cs_base = cs_base;
tb->flags = flags;
tb->cflags = cflags;
+ tb->invalid = false;
#ifdef CONFIG_PROFILER
tcg_ctx.tb_count1++; /* includes aborted translations because of
--
2.7.4
- [Qemu-devel] [PATCH v5 0/7] tcg: allocate TB structs preceding translate, (continued)
- [Qemu-devel] [PATCH v5 0/7] tcg: allocate TB structs preceding translate, Richard Henderson, 2017/06/09
- [Qemu-devel] [PATCH v5 3/7] tcg/aarch64: Use ADR in tcg_out_movi, Richard Henderson, 2017/06/09
- [Qemu-devel] [PATCH v5 1/7] util: add cacheinfo, Richard Henderson, 2017/06/09
- [Qemu-devel] [PATCH v5 4/7] tcg/arm: Use indirect branch for goto_tb, Richard Henderson, 2017/06/09
- [Qemu-devel] [PATCH v5 2/7] tcg: allocate TB structs before the corresponding translated code, Richard Henderson, 2017/06/09
- [Qemu-devel] [PATCH v5 5/7] tcg/arm: Remove limit on code buffer size, Richard Henderson, 2017/06/09
- [Qemu-devel] [PATCH v5 6/7] tcg/arm: Try pc-relative addresses for movi, Richard Henderson, 2017/06/09
- [Qemu-devel] [PATCH v5 7/7] tcg/arm: Use ldr (literal) for goto_tb, Richard Henderson, 2017/06/09
- Re: [Qemu-devel] [PATCH v5 0/7] tcg: allocate TB structs preceding translate, no-reply, 2017/06/09
- Re: [Qemu-devel] [PATCH v5 0/7] tcg: allocate TB structs preceding translate, Emilio G. Cota, 2017/06/09