[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/2] Unit test+fix for problem with QEMU handlin
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH 0/2] Unit test+fix for problem with QEMU handling of multiple bind()s to the same port |
Date: |
Fri, 9 Jun 2017 14:16:27 -0700 (PDT) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH 0/2] Unit test+fix for problem with QEMU handling
of multiple bind()s to the same port
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
016f28c socket: Handle race condition between binds to the same port
b4ff650 Add test-listen - a stress test for QEMU socket listen
=== OUTPUT BEGIN ===
Checking PATCH 1/2: Add test-listen - a stress test for QEMU socket listen...
ERROR: line over 90 characters
#173: FILE: tests/test-listen.c:99:
+ printf("** Failed to assign a port to thread %d (errno = %d)\n",
i, thr[i].eno);
WARNING: line over 80 characters
#177: FILE: tests/test-listen.c:103:
+ g_assert(strstr(thr[i].errstr, "Failed to listen on socket") !=
NULL);
total: 1 errors, 1 warnings, 149 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 2/2: socket: Handle race condition between binds to the same
port...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-devel] [PATCH 0/2] Unit test+fix for problem with QEMU handling of multiple bind()s to the same port, Knut Omang, 2017/06/09
- [Qemu-devel] [PATCH 2/2] socket: Handle race condition between binds to the same port, Knut Omang, 2017/06/09
- [Qemu-devel] [PATCH 1/2] Add test-listen - a stress test for QEMU socket listen, Knut Omang, 2017/06/09
- Re: [Qemu-devel] [PATCH 0/2] Unit test+fix for problem with QEMU handling of multiple bind()s to the same port, no-reply, 2017/06/09
- Re: [Qemu-devel] [PATCH 0/2] Unit test+fix for problem with QEMU handling of multiple bind()s to the same port, Eric Blake, 2017/06/09
- Re: [Qemu-devel] [PATCH 0/2] Unit test+fix for problem with QEMU handling of multiple bind()s to the same port, no-reply, 2017/06/09
- Re: [Qemu-devel] [PATCH 0/2] Unit test+fix for problem with QEMU handling of multiple bind()s to the same port,
no-reply <=