[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] bdrv_inc_in_flight and bdrv_dec_in_flight:
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH] bdrv_inc_in_flight and bdrv_dec_in_flight: |
|
Date: |
Sat, 10 Jun 2017 22:08:31 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 06/10/2017 02:04 AM, Zhengui Li wrote:
> Avoid empty pointer access if the bs is NULL.
>
> Signed-off-by: Zhengui Li <address@hidden>
> ---
> block/io.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
NACK; this is fixing a symptom, not the problem. If you have a coredump
due to a bad caller passing in NULL, then post the backtrace and let's
fix the broken caller instead.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature