qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 5/7] pci: Replace pci_add_capability() with p


From: Mao Zhongyi
Subject: Re: [Qemu-devel] [PATCH v4 5/7] pci: Replace pci_add_capability() with pci_add_capability2()
Date: Mon, 12 Jun 2017 09:34:14 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0

Hi, Eduardo

On 06/09/2017 09:53 PM, Eduardo Habkost wrote:
On Fri, Jun 09, 2017 at 07:24:40PM +0800, Mao Zhongyi wrote:
After the patch 'Make errp the last parameter of pci_add_capability()',
pci_add_capability() and pci_add_capability2() now do exactly the same.
So drop the wrapper pci_add_capability() of pci_add_capability2(), then
replace the pci_add_capability() with pci_add_capability2() everywhere.

I would do the opposite, and keep pci_add_capability() only.
It's confusing to have a function named pci_add_capability2() if
pci_add_capability() doesn't exist anymore.


Yes, I see, will fix it right away.

Thanks
Mao





reply via email to

[Prev in Thread] Current Thread [Next in Thread]