[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/6] fw_cfg: move setting of FW_CFG_ID into fw_c
|
From: |
Mark Cave-Ayland |
|
Subject: |
Re: [Qemu-devel] [PATCH 3/6] fw_cfg: move setting of FW_CFG_ID into fw_cfg_init1() |
|
Date: |
Mon, 12 Jun 2017 12:49:57 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 12/06/17 12:37, Igor Mammedov wrote:
> On Sat, 10 Jun 2017 13:30:18 +0100
> Mark Cave-Ayland <address@hidden> wrote:
>
>> The dma_enabled property enables us to set the FW_CFG_ID version
>> accordingly.
> it might be not safe as patch reorders FW_CFG_ID entry.
>
> (I recall there were patches that sorted fwcfg entries,
> but it's worth checking that it won't break migration)
>
> CCing Gerd, maybe he would recall how it works.
Ah so the order in fw_cfg needs to be preserved? (my assumption was that
the slot-id also specified the order). I'll have a look and see if I can
fix this with a simple re-ordering.
ATB,
Mark.
- [Qemu-devel] [PATCH 1/6] fw_cfg: move initialisation of FWCfgState into instance_init, (continued)
- [Qemu-devel] [PATCH 1/6] fw_cfg: move initialisation of FWCfgState into instance_init, Mark Cave-Ayland, 2017/06/10
- [Qemu-devel] [PATCH 5/6] fw_cfg: use sysbus_init_mmio() in fw_cfg_io_realize(), Mark Cave-Ayland, 2017/06/10
- [Qemu-devel] [PATCH 3/6] fw_cfg: move setting of FW_CFG_ID into fw_cfg_init1(), Mark Cave-Ayland, 2017/06/10
- [Qemu-devel] [PATCH 4/6] fw_cfg: move fw_cfg_init1() into the fw_cfg_*_realize() functions, Mark Cave-Ayland, 2017/06/10
- Re: [Qemu-devel] [PATCH 0/6] fw_cfg: qdev-related tidy-ups, Philippe Mathieu-Daudé, 2017/06/10