qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3] block: change variable names in BlockDriverS


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH v3] block: change variable names in BlockDriverState
Date: Mon, 12 Jun 2017 15:23:39 +0100
User-agent: Mutt/1.8.0 (2017-02-23)

On Fri, Jun 09, 2017 at 01:18:08PM +0300, Manos Pitsidianakis wrote:
> Change the 'int count' parameter in *pwrite_zeros, *pdiscard related
> functions (and some others) to 'int bytes', as they both refer to bytes.
> This helps with code legibility.
> 
> Signed-off-by: Manos Pitsidianakis <address@hidden>
> ---

Please include a changelog beneath '---' in future patches.  For
example:

v3:
 * Drop ide change which operated on sectors, not bytes [Stefan]

>  block/blkdebug.c               | 36 +++++++++++++++----------------
>  block/blkreplay.c              |  8 +++----
>  block/block-backend.c          | 22 +++++++++----------
>  block/file-posix.c             | 34 +++++++++++++++---------------
>  block/io.c                     | 48 
> +++++++++++++++++++++---------------------
>  block/iscsi.c                  | 20 +++++++++---------
>  block/mirror.c                 |  8 +++----
>  block/nbd-client.c             |  8 +++----
>  block/nbd-client.h             |  4 ++--
>  block/qcow2.c                  | 28 ++++++++++++------------
>  block/qed.c                    |  8 +++----
>  block/raw-format.c             |  8 +++----
>  block/rbd.c                    |  4 ++--
>  block/sheepdog.c               |  6 +++---
>  include/block/block.h          |  8 +++----
>  include/block/block_int.h      |  6 +++---
>  include/sysemu/block-backend.h | 20 +++++++++---------
>  qemu-io-cmds.c                 | 46 ++++++++++++++++++++--------------------
>  18 files changed, 161 insertions(+), 161 deletions(-)

Reviewed-by: Stefan Hajnoczi <address@hidden>

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]