Re: [Qemu-devel] [PATCH v4 4/7] target-m68k: move fmove CR to a function

[Laurent Vivier]

Le 12/06/2017 à 18:13, Richard Henderson a écrit :
> On 06/11/2017 04:16 PM, Laurent Vivier wrote:
>> Move code of fmove to/from control register to a function
>>
>> Signed-off-by: Laurent Vivier <address@hidden>
>> ---
>>   target/m68k/translate.c | 66
>> ++++++++++++++++++++++++++++++-------------------
>>   1 file changed, 41 insertions(+), 25 deletions(-)
> 
> In that this is 100% code movement,
> 
> Reviewed-by: Richard Henderson <address@hidden>
> 
> 
>> +            cpu_abort(NULL, "Unimplemented: fmove from control %d",
>> mask);
>> +            goto undef;
> 
> But cpu_abort doesn't return, and will exit qemu.
> This should be qemu_log_mask(LOG_UNIMP, ...).

Do you want I update the patch to fix that?

Thanks,
Laurent