[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/5] migration: Create load_setup()/cleanup() me
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH 3/5] migration: Create load_setup()/cleanup() methods |
Date: |
Tue, 13 Jun 2017 11:57:21 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Kevin Wolf <address@hidden> wrote:
> Am 02.06.2017 um 00:15 hat Juan Quintela geschrieben:
>> We need to do things at load time.
>>
>> Signed-off-by: Juan Quintela <address@hidden>
>> ---
>> include/migration/register.h | 2 ++
>> migration/savevm.c | 31 +++++++++++++++++++++++++++++++
>> 2 files changed, 33 insertions(+)
>>
>> diff --git a/include/migration/register.h b/include/migration/register.h
>> index 8e37185..0862bb8 100644
>> --- a/include/migration/register.h
>> +++ b/include/migration/register.h
>> @@ -42,6 +42,8 @@ typedef struct SaveVMHandlers {
>> uint64_t *non_postcopiable_pending,
>> uint64_t *postcopiable_pending);
>> LoadStateHandler *load_state;
>> + int (*load_setup)(QEMUFile *f, void *opaque);
>> + int (*load_cleanup)(void *opaque);
>> } SaveVMHandlers;
>
> I see that you add code to call load_setup(), but don't you want to call
> load_cleanup() somewhere, too?
Oops, you are right.
I just sent another version of this series. They are built on top of my
pull request. And I added the call to load_cleanup.
Thanks for the review, Juan.
- [Qemu-devel] [PATCH 0/5] Create setup/cleanup methods for migration incoming side, Juan Quintela, 2017/06/01
- [Qemu-devel] [PATCH 1/5] migration: Rename save_live_setup() to save_setup(), Juan Quintela, 2017/06/01
- [Qemu-devel] [PATCH 2/5] migration: Rename cleanup() to save_cleanup(), Juan Quintela, 2017/06/01
- [Qemu-devel] [PATCH 3/5] migration: Create load_setup()/cleanup() methods, Juan Quintela, 2017/06/01
- [Qemu-devel] [PATCH 4/5] migration: Convert ram to use new load_setup()/load_cleanup(), Juan Quintela, 2017/06/01
- [Qemu-devel] [PATCH 5/5] migration: Make compression_threads use save/load_setup/cleanup(), Juan Quintela, 2017/06/01
- Re: [Qemu-devel] [PATCH 0/5] Create setup/cleanup methods for migration incoming side, Juan Quintela, 2017/06/07