Re: [Qemu-devel] [PATCH] virtio-blk: drain block before cleanup

[Gi-Oh Kim]

On Tue, Jun 13, 2017 at 12:19 PM,  <address@hidden> wrote:
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
>
> Type: series
> Subject: [Qemu-devel] [PATCH] virtio-blk: drain block before cleanup
> Message-id: address@hidden
>
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
>
> BASE=base
> n=1
> total=$(git log --oneline $BASE.. | wc -l)
> failed=0
>
> git config --local diff.renamelimit 0
> git config --local diff.renames True
>
> commits="$(git log --format=%H --reverse $BASE..)"
> for c in $commits; do
>     echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
>     if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; 
> then
>         failed=1
>         echo
>     fi
>     n=$((n+1))
> done
>
> exit $failed
> === TEST SCRIPT END ===
>
> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
> From https://github.com/patchew-project/qemu
>  * [new tag]         patchew/address@hidden -> patchew/address@hidden
>  * [new tag]         patchew/address@hidden -> patchew/address@hidden
> Switched to a new branch 'test'
> 4b981d6 virtio-blk: drain block before cleanup
>
> === OUTPUT BEGIN ===
> Checking PATCH 1/1: virtio-blk: drain block before cleanup...
> ERROR: braces {} are necessary for all arms of this statement
> #157: FILE: hw/block/virtio-blk.c:976:
> +    if (blk_bs(s->blk) && bdrv_requests_pending((blk_bs(s->blk))))
> [...]
>
> total: 1 errors, 0 warnings, 8 lines checked
>
> Your patch has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
>
> === OUTPUT END ===
>

Yes, it has a problem.
I'll send 2nd patch after fixing it.

-- 
Best regards,
Gi-Oh Kim
TEL: 0176 2697 8962