[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 05/16] block/file-posix: Small fixes in raw_creat
From: |
Max Reitz |
Subject: |
[Qemu-devel] [PATCH v4 05/16] block/file-posix: Small fixes in raw_create() |
Date: |
Tue, 13 Jun 2017 22:20:56 +0200 |
Variables should be declared at the start of a block, and if a certain
parameter value is not supported it may be better to return -ENOTSUP
instead of -EINVAL.
Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
---
block/file-posix.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/block/file-posix.c b/block/file-posix.c
index 30d2245..a020198 100644
--- a/block/file-posix.c
+++ b/block/file-posix.c
@@ -1910,6 +1910,8 @@ static int raw_create(const char *filename, QemuOpts
*opts, Error **errp)
#endif
case PREALLOC_MODE_FULL:
{
+ int64_t num = 0, left = total_size;
+
/*
* Knowing the final size from the beginning could allow the file
* system driver to do less allocations and possibly avoid
@@ -1921,7 +1923,6 @@ static int raw_create(const char *filename, QemuOpts
*opts, Error **errp)
goto out_close;
}
- int64_t num = 0, left = total_size;
buf = g_malloc0(65536);
while (left > 0) {
@@ -1953,7 +1954,7 @@ static int raw_create(const char *filename, QemuOpts
*opts, Error **errp)
}
break;
default:
- result = -EINVAL;
+ result = -ENOTSUP;
error_setg(errp, "Unsupported preallocation mode: %s",
PreallocMode_lookup[prealloc]);
break;
--
2.9.4
- [Qemu-devel] [PATCH v4 00/16] block: Preallocated truncate, Max Reitz, 2017/06/13
- [Qemu-devel] [PATCH v4 01/16] block: Add PreallocMode to BD.bdrv_truncate(), Max Reitz, 2017/06/13
- [Qemu-devel] [PATCH v4 02/16] block: Add PreallocMode to bdrv_truncate(), Max Reitz, 2017/06/13
- [Qemu-devel] [PATCH v4 03/16] block: Add PreallocMode to blk_truncate(), Max Reitz, 2017/06/13
- [Qemu-devel] [PATCH v4 04/16] qemu-img: Expose PreallocMode for resizing, Max Reitz, 2017/06/13
- [Qemu-devel] [PATCH v4 05/16] block/file-posix: Small fixes in raw_create(),
Max Reitz <=
- [Qemu-devel] [PATCH v4 06/16] block/file-posix: Extract raw_regular_truncate(), Max Reitz, 2017/06/13
- [Qemu-devel] [PATCH v4 09/16] block/qcow2: Generalize preallocate(), Max Reitz, 2017/06/13
- [Qemu-devel] [PATCH v4 07/16] block/file-posix: Generalize raw_regular_truncate, Max Reitz, 2017/06/13
- [Qemu-devel] [PATCH v4 08/16] block/file-posix: Preallocation for truncate, Max Reitz, 2017/06/13
- [Qemu-devel] [PATCH v4 10/16] block/qcow2: Lock s->lock in preallocate(), Max Reitz, 2017/06/13
- [Qemu-devel] [PATCH v4 11/16] block/qcow2: Metadata preallocation for truncate, Max Reitz, 2017/06/13
- [Qemu-devel] [PATCH v4 12/16] block/qcow2: Add qcow2_refcount_area(), Max Reitz, 2017/06/13
- [Qemu-devel] [PATCH v4 13/16] block/qcow2: Rename "fail_block" to just "fail", Max Reitz, 2017/06/13
- [Qemu-devel] [PATCH v4 14/16] block/qcow2: falloc/full preallocating growth, Max Reitz, 2017/06/13
- [Qemu-devel] [PATCH v4 15/16] iotests: Add preallocated resize test for raw, Max Reitz, 2017/06/13