qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RFC v19 01/13] target-avr: AVR cores support is


From: Thomas Huth
Subject: Re: [Qemu-devel] [PATCH RFC v19 01/13] target-avr: AVR cores support is added.
Date: Wed, 14 Jun 2017 07:19:09 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0

On 13.06.2017 22:32, Michael Rolnik wrote:
> the last version of my patches were done by Richard. Now I just
> reapplied them to the master. 
> Should I have to remove "signed-off-by Richard" ?

OK, if Richard did change to your patches, you should likely keep the
line. But I think you should remove the "Message-Id" line when sending
patches to the list, since that is normally only used by maintainers
when they finally pick up the patches. Otherwise this looks very
confusing (since the new v19 version has a different Message-Id in the
mail header).

 Thomas


> On Tue, Jun 13, 2017 at 11:09 PM, Thomas Huth <address@hidden
> <mailto:address@hidden>> wrote:
> 
>     On 08.06.2017 20:49, Michael Rolnik wrote:
>     >     1. basic CPU structure
>     >     2. registers
>     >     3. no instructions
>     >     4. saving sreg, rampD, rampX, rampY, rampD, eind in HW 
> representation
>     >
>     > Signed-off-by: Michael Rolnik <address@hidden <mailto:address@hidden>>
>     > Message-Id: <address@hidden
>     <mailto:address@hidden>>
>     > Signed-off-by: Richard Henderson <address@hidden 
> <mailto:address@hidden>>
> 
>     Why is the final "Signed-off-by" by Richard, if the patch has apparently
>     been sent by you, Michael? Something is wrong here with the order...
> 
>      Thomas




reply via email to

[Prev in Thread] Current Thread [Next in Thread]