Re: [Qemu-devel] [PULL 00/10] TCG queued patches

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PULL 00/10] TCG queued patches
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
dc85a04 tcg: Remove tb_htable_lookup from helper_lookup_tb_ptr
a4aec38 Revert "target/aarch64: optimize indirect branches"
3eedfe9 tcg/arm: Use ldr (literal) for goto_tb
6b513d9 tcg/arm: Try pc-relative addresses for movi
1113498 tcg/arm: Remove limit on code buffer size
4e2f272 tcg/arm: Use indirect branch for goto_tb
1eb7d2f tcg/aarch64: Use ADR in tcg_out_movi
37d54b2 translate-all: consolidate tb init in tb_gen_code
ee24c68 tcg: allocate TB structs before the corresponding translated code
aadff9f util: add cacheinfo

=== OUTPUT BEGIN ===
Checking PATCH 1/10: util: add cacheinfo...
ERROR: do not initialise globals to 0 or NULL
#149: FILE: util/cacheinfo.c:11:
+int qemu_icache_linesize = 0;

ERROR: do not initialise globals to 0 or NULL
#150: FILE: util/cacheinfo.c:12:
+int qemu_dcache_linesize = 0;

ERROR: space prohibited after that '&&' (ctx:ExW)
#191: FILE: util/cacheinfo.c:53:
+            && buf[i].Cache.Level == 1) {
             ^

WARNING: architecture specific defines should be avoided
#214: FILE: util/cacheinfo.c:76:
+# if defined(__APPLE__)

WARNING: architecture specific defines should be avoided
#248: FILE: util/cacheinfo.c:110:
+#if defined(__aarch64__)

total: 3 errors, 2 warnings, 218 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/10: tcg: allocate TB structs before the corresponding 
translated code...
Checking PATCH 3/10: translate-all: consolidate tb init in tb_gen_code...
Checking PATCH 4/10: tcg/aarch64: Use ADR in tcg_out_movi...
Checking PATCH 5/10: tcg/arm: Use indirect branch for goto_tb...
Checking PATCH 6/10: tcg/arm: Remove limit on code buffer size...
Checking PATCH 7/10: tcg/arm: Try pc-relative addresses for movi...
Checking PATCH 8/10: tcg/arm: Use ldr (literal) for goto_tb...
Checking PATCH 9/10: Revert "target/aarch64: optimize indirect branches"...
Checking PATCH 10/10: tcg: Remove tb_htable_lookup from helper_lookup_tb_ptr...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden