qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] 答复: Re: 答复: Re: [PATCHv2 02/04] colo-compare: Process


From: Jason Wang
Subject: Re: [Qemu-devel] 答复: Re: 答复: Re: [PATCHv2 02/04] colo-compare: Process pactkets in the IOThread ofthe primary
Date: Thu, 15 Jun 2017 12:23:27 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1



On 2017年06月13日 19:24, address@hidden wrote:

>>Char-fe.c for sure which means frontend of chardev.


>>> These API can only watch events in the qemu main thread, not in the

>>> IOThread.

>>>

>>> I had to use the qio_channel_socket_set_aio_fd_handler function to

>>>

>>> monitor the char event in the IOThread,so the io channel is used her

>>>


>>The point is not touching the internal structure of chardev like ioc,

>>instead extend its helper like e.g qemu_chr_fe_set_handlers() and let it

>>set aio handlers,


>Currently character devices are tied to the GSource API. However,I'll try to submit a patch first.


Hi Jason,


I have investigated the change, which involves a great deal.

We have to convert the user of those APIs (the external API is

qemu_chr_fe_add_watch) from GSource/QIOChannel to AioContext.


Can we join this series first? and replace GSource with AioContext in a future patch.



Touching internal chardev member out of its scope is bad, we need to seek a solution for this.

Paolo, Marc and Stefan:

We want let chardev front-end run in colo comparing IOThread. This looks not supported by current chardev frontend API. Any idea/suggestion on how to achieve this?

Thanks



reply via email to

[Prev in Thread] Current Thread [Next in Thread]