[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] util: remove the obsolete non-blocking connect
|
From: |
Daniel P. Berrange |
|
Subject: |
Re: [Qemu-devel] [PATCH] util: remove the obsolete non-blocking connect |
|
Date: |
Thu, 15 Jun 2017 09:54:58 +0100 |
|
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Thu, Jun 15, 2017 at 11:08:01AM +0800, Mao Zhongyi wrote:
> From: Cao jin <address@hidden>
>
> The non-blocking connect mechanism is obsolete, and it doesn't
> work well in inet connection, because it will call getaddrinfo
> first and getaddrinfo will blocks on DNS lookups. Since commit
> e65c67e4 & d984464e, the non-blocking connect of migration goes
> through QIOChannel in a different manner(using a thread), and
> nobody use this old non-blocking connect anymore.
>
> Any newly written code which needs a non-blocking connect should
> use the QIOChannel code, so we can drop NonBlockingConnectHandler
> as a concept entirely.
>
> Cc: address@hidden
> Cc: address@hidden
> Cc: address@hidden
> Cc: address@hidden
> Cc: address@hidden
> Cc: address@hidden
> Cc: address@hidden
> Cc: address@hidden
> Cc: address@hidden
> Cc: address@hidden
> Suggested-by: Daniel P. Berrange <address@hidden>
> Signed-off-by: Cao jin <address@hidden>
> Signed-off-by: Mao Zhongyi <address@hidden>
> ---
Reviewed-by: Daniel P. Berrange <address@hidden>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|