Re: [Qemu-devel] [PATCH v2 2/5] target/alpha: Use tcg_gen_lookup_and_goto_ptr

[Richard Henderson]

On 06/15/2017 02:57 PM, Philippe Mathieu-Daudé wrote:
> Peter cleaned that and improved the doc on ARM:
> https://patchwork.kernel.org/patch/9690993/
> (commit b636649f5a2e108413dd171edaf320f781f57942)
>
> $ git grep -- singlestep_enabled target|wc -l
> 113
> still confusing...

This is two of the three single step conditions.
Not including the split I describe below.


r~


> > > > -        || ctx->singlestep_enabled || singlestep) {
> >
> >
> > I didn't start testing this global.  It's already there.
> >
> > Further, despite the name similarity these are very different conditions.
> >
> > For ctx->singlestep_enabled we emit a debug exception at the end of every
> > instruction.
> >
> > For singlestep, we must execute only one insn in the TB and further we must
> > return to the main loop after the TB.  Both are required for -singlestep -d
> > cpu to log all that's being requested.
> >
> > One cannot combine the two conditions.
> >
> >
> > r~