qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [Qemu-arm] [PATCH] target-arm: Bug fix in filling the c


From: Philippe Mathieu-Daudé
Subject: Re: [Qemu-devel] [Qemu-arm] [PATCH] target-arm: Bug fix in filling the cp_regs hashtable
Date: Fri, 16 Jun 2017 12:36:45 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0

On 06/16/2017 11:51 AM, Peter Maydell wrote:
On 16 June 2017 at 15:42, Abdallah Bouassida
<address@hidden> wrote:
Check if the CPU supports AARCH64 before adding  the 64bit view of
the coprocessor's register to the cp_regs hashtable.

Signed-off-by: Abdallah Bouassida <address@hidden>
---
Bug description: if a register has the .state = ARM_CP_STATE_BOTH, its 64bit
view will be added to the hashtable even if the CPU is not 64bit.

This is deliberate and required. Where the AArch64 and AArch32
states both have a register which shares underlying architectural
state, QEMU chooses to implement migration of that state usually
via the AArch64 version's ARMCPRegInfo struct. If the AArch64
version is not included in the hashtable for an AArch32-only
CPU then the state of the 32-bit register won't be migrated.
The AArch64 register is of course invisible to the guest because
it is only accessible via 64-bit instructions, but it's used
during migration.

explanation worth to go as comment in the source!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]