[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target/mips: fix msa copy_[s|u]_df rd = 0 corne
|
From: |
Aurelien Jarno |
|
Subject: |
Re: [Qemu-devel] [PATCH] target/mips: fix msa copy_[s|u]_df rd = 0 corner case |
|
Date: |
Sun, 18 Jun 2017 01:05:33 +0200 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
On 2017-06-15 16:20, Miodrag Dinic wrote:
> From: Miodrag Dinic <address@hidden>
>
> This patch fixes the msa copy_[s|u]_df instruction emulation when
> the destination register rd is zero. Without this patch the zero
> register would get clobbered, which should never happen because it
> is supposed to be hardwired to 0.
>
> Fix this corner case by explicitly checking rd = 0 and effectively
> making these instructions emulation no-op in that case.
>
> Signed-off-by: Miodrag Dinic <address@hidden>
> ---
> target/mips/translate.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
Reviewed-by: Aurelien Jarno <address@hidden>
Acked-by: Aurelien Jarno <address@hidden>
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
address@hidden http://www.aurel32.net