Re: [Qemu-devel] [PATCH 0/1] Add fmask/dmask option for 9p mapped mode

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Type: series
Subject: [Qemu-devel] [PATCH 0/1] Add fmask/dmask option for 9p mapped mode

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
3fa3c8f Add support for custom fmasks/dmasks in 9ps mapped mode

=== OUTPUT BEGIN ===
Checking PATCH 1/1: Add support for custom fmasks/dmasks in 9ps mapped mode...
ERROR: consider using qemu_strtol in preference to strtol
#117: FILE: hw/9pfs/9p-local.c:1477:
+        mask = strtol(fmask, NULL, 0);

ERROR: that open brace { should be on the previous line
#118: FILE: hw/9pfs/9p-local.c:1478:
+        if((!mask || mask == LONG_MIN || mask == LONG_MAX) && errno)
+        {

ERROR: space required before the open parenthesis '('
#118: FILE: hw/9pfs/9p-local.c:1478:
+        if((!mask || mask == LONG_MIN || mask == LONG_MAX) && errno)

ERROR: code indent should never use tabs
#122: FILE: hw/9pfs/9p-local.c:1482:
+^I}$

ERROR: consider using qemu_strtol in preference to strtol
#128: FILE: hw/9pfs/9p-local.c:1488:
+        mask = strtol(dmask, NULL, 0);

ERROR: that open brace { should be on the previous line
#129: FILE: hw/9pfs/9p-local.c:1489:
+        if((!mask || mask == LONG_MIN || mask == LONG_MAX) && errno)
+        {

ERROR: space required before the open parenthesis '('
#129: FILE: hw/9pfs/9p-local.c:1489:
+        if((!mask || mask == LONG_MIN || mask == LONG_MAX) && errno)

ERROR: code indent should never use tabs
#133: FILE: hw/9pfs/9p-local.c:1493:
+^I}$

total: 8 errors, 0 warnings, 118 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden