[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v2 13/41] q35: fix get_mmcfg_size to use uint64 visit
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PULL v2 13/41] q35: fix get_mmcfg_size to use uint64 visitor |
Date: |
Tue, 20 Jun 2017 14:40:40 +0200 |
From: Marc-André Lureau <address@hidden>
e->size is hwaddr, i.e. uint64_t. We silently truncate.
Signed-off-by: Marc-André Lureau <address@hidden>
Suggested-by: Markus Armbruster <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
---
hw/pci-host/q35.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c
index cd5c496..e8a04d3 100644
--- a/hw/pci-host/q35.c
+++ b/hw/pci-host/q35.c
@@ -129,9 +129,8 @@ static void q35_host_get_mmcfg_size(Object *obj, Visitor
*v, const char *name,
void *opaque, Error **errp)
{
PCIExpressHost *e = PCIE_HOST_BRIDGE(obj);
- uint32_t value = e->size;
- visit_type_uint32(v, name, &value, errp);
+ visit_type_uint64(v, name, &e->size, errp);
}
static Property mch_props[] = {
--
2.7.5
- [Qemu-devel] [PULL v2 00/41] QAPI patches for 2017-06-09, Markus Armbruster, 2017/06/20
- [Qemu-devel] [PULL v2 02/41] object: fix potential leak in getters, Markus Armbruster, 2017/06/20
- [Qemu-devel] [PULL v2 04/41] tests: add more int/number ranges checks, Markus Armbruster, 2017/06/20
- [Qemu-devel] [PULL v2 03/41] tests: Remove test cases for alternates of 'number' and 'int', Markus Armbruster, 2017/06/20
- [Qemu-devel] [PULL v2 05/41] qapi: Clean up qobject_input_type_number() control flow, Markus Armbruster, 2017/06/20
- [Qemu-devel] [PULL v2 01/41] qdev: remove PropertyInfo.qtype field, Markus Armbruster, 2017/06/20
- [Qemu-devel] [PULL v2 08/41] tests: remove /{qnum, qlist, dict}/destroy test, Markus Armbruster, 2017/06/20
- [Qemu-devel] [PULL v2 13/41] q35: fix get_mmcfg_size to use uint64 visitor,
Markus Armbruster <=
- [Qemu-devel] [PULL v2 09/41] qnum: add uint type, Markus Armbruster, 2017/06/20
- [Qemu-devel] [PULL v2 10/41] json: learn to parse uint64 numbers, Markus Armbruster, 2017/06/20
- [Qemu-devel] [PULL v2 11/41] qapi: update the qobject visitor to use QNUM_U64, Markus Armbruster, 2017/06/20
- [Qemu-devel] [PULL v2 14/41] object: use more specific property type names, Markus Armbruster, 2017/06/20
- [Qemu-devel] [PULL v2 24/41] aspeed: use {set, get}_uint() for "ram-size" property, Markus Armbruster, 2017/06/20
- [Qemu-devel] [PULL v2 28/41] acpi: use get_uint() for various acpi properties, Markus Armbruster, 2017/06/20
- [Qemu-devel] [PULL v2 25/41] bcm2835_fb: use {get, set}_uint() for "vcram-size" and "vcram-base", Markus Armbruster, 2017/06/20
- [Qemu-devel] [PULL v2 20/41] isa: use get_uint() for "io-base", Markus Armbruster, 2017/06/20
- [Qemu-devel] [PULL v2 19/41] qdev: Use appropriate getter/setters type, Markus Armbruster, 2017/06/20
- [Qemu-devel] [PULL v2 07/41] qapi: Remove visit_start_alternate() parameter promote_int, Markus Armbruster, 2017/06/20