Re: [Qemu-devel] [PATCH v1 0/3] target/s390x: implement idte and improve ipte

[David Hildenbrand]

On 20.06.2017 14:35, David Hildenbrand wrote:
> One step into the direction of adding the DAT-enhancement facility.
> 
> To improve the TLB flushing, we will have to remember each used table (or
> at least a hash!) for each tlb entry, just like real HW does.
> 
> idte is pretty much untested, before I can test it with linux (by enabling
> DAT-enhancement) we will have to implement cspg. Will look into this next.
> 
> David Hildenbrand (3):
>   target/s390x: Indicate and check for local tlb clearing
>   target/s390x: Improve heuristic for ipte
>   target/s390x: Implement idte instruction
> 
>  target/s390x/cpu_models.c  |  1 +
>  target/s390x/helper.h      |  1 +
>  target/s390x/insn-data.def |  2 ++
>  target/s390x/mem_helper.c  | 80 
> +++++++++++++++++++++++++++++++++++++++-------
>  target/s390x/translate.c   | 11 +++++++
>  5 files changed, 83 insertions(+), 12 deletions(-)
> 

Just realized that cspg is already implemented. By forcing
DAT-Enhacement on, my Linux guests crashes at some point. So either
invalidation in idte is still wrong or cspg is broken. Will look into it.

-- 

Thanks,

David