Re: [Qemu-devel] [PATCH 13/15] tcg: disable tcg in CPUX86State struct

[Richard Henderson]

On 06/21/2017 03:19 AM, Yang Zhong wrote:
> --- a/target/i386/cpu.h
> +++ b/target/i386/cpu.h
> @@ -52,7 +52,9 @@
>   
>   #include "exec/cpu-defs.h"
>   
> +#ifdef CONFIG_TCG
>   #include "fpu/softfloat.h"
> +#endif
>   
>   #define R_EAX 0
>   #define R_ECX 1
> @@ -1130,8 +1132,9 @@ typedef struct CPUX86State {
>   
>       /* Fields up to this point are cleared by a CPU reset */
>       struct {} end_reset_fields;
> -
> +#ifdef CONFIG_TCG
>       CPU_COMMON
> +#endif

This is at the wrong level.  If !CONFIG_TCG, then CPU_COMMON should be empty.


r~