[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH RFC v3 3/8] block: add throttle blo
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH RFC v3 3/8] block: add throttle block filter driver |
Date: |
Tue, 27 Jun 2017 13:45:40 +0100 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Mon, Jun 26, 2017 at 07:26:41PM +0300, Manos Pitsidianakis wrote:
> On Mon, Jun 26, 2017 at 03:30:55PM +0100, Stefan Hajnoczi wrote:
> > > + bs->file = bdrv_open_child(NULL, options, "file",
> > > + bs, &child_file, false, &local_err);
> > > +
> > > + if (local_err) {
> > > + error_propagate(errp, local_err);
> > > + return -EINVAL;
> > > + }
> > > +
> > > + qdict_flatten(options);
> > > + return throttle_configure_tgm(bs, tgm, options, errp);
> >
> > Who destroys bs->file on error?
>
> It is reaped by bdrv_open_inherit() on failure, if I'm not mistaken.
> That's how other drivers handle this as well. Some (eg block/qcow2.c)
> check if bs->file is NULL instead of the error pointer they pass, so
> this is not not very consistent.
Maybe I'm missing it but I don't see relevant bs->file cleanup in
bdrv_open_inherit() or bdrv_open_common().
Please post the exact line where it happens.
Stefan
signature.asc
Description: PGP signature
- Re: [Qemu-devel] [PATCH RFC v3 5/8] block: add BlockDevOptionsThrottle to QAPI, (continued)
- [Qemu-devel] [PATCH RFC v3 3/8] block: add throttle block filter driver, Manos Pitsidianakis, 2017/06/23
- Re: [Qemu-devel] [Qemu-block] [PATCH RFC v3 3/8] block: add throttle block filter driver, Manos Pitsidianakis, 2017/06/26
- Re: [Qemu-devel] [Qemu-block] [PATCH RFC v3 3/8] block: add throttle block filter driver, Stefan Hajnoczi, 2017/06/26
- Re: [Qemu-devel] [Qemu-block] [PATCH RFC v3 3/8] block: add throttle block filter driver, Manos Pitsidianakis, 2017/06/26
- Re: [Qemu-devel] [Qemu-block] [PATCH RFC v3 3/8] block: add throttle block filter driver,
Stefan Hajnoczi <=
- Re: [Qemu-devel] [Qemu-block] [PATCH RFC v3 3/8] block: add throttle block filter driver, Manos Pitsidianakis, 2017/06/27
- Re: [Qemu-devel] [Qemu-block] [PATCH RFC v3 3/8] block: add throttle block filter driver, Stefan Hajnoczi, 2017/06/28
Re: [Qemu-devel] [Qemu-block] [PATCH RFC v3 3/8] block: add throttle block filter driver, Stefan Hajnoczi, 2017/06/26
Re: [Qemu-devel] [PATCH RFC v3 3/8] block: add throttle block filter driver, Kevin Wolf, 2017/06/28
[Qemu-devel] [PATCH RFC v3 1/8] block: move ThrottleGroup membership to ThrottleGroupMember, Manos Pitsidianakis, 2017/06/23