Re: [Qemu-devel] [PATCH] xsave_helper: pull xsave and xrstor out of kvm.c into helper function

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH] xsave_helper: pull xsave and xrstor out of kvm.c 
into helper function
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
0a6ed4b xsave_helper: pull xsave and xrstor out of kvm.c into helper function

=== OUTPUT BEGIN ===
Checking PATCH 1/1: xsave_helper: pull xsave and xrstor out of kvm.c into 
helper function...
ERROR: spaces required around that '+' (ctx:VxV)
#211: FILE: target/i386/xsave_helper.c:47:
+        stq_p(xmm+8,   env->xmm_regs[i].ZMM_Q(1));
                  ^

ERROR: spaces required around that '+' (ctx:VxV)
#213: FILE: target/i386/xsave_helper.c:49:
+        stq_p(ymmh+8,  env->xmm_regs[i].ZMM_Q(3));
                   ^

ERROR: spaces required around that '+' (ctx:VxV)
#215: FILE: target/i386/xsave_helper.c:51:
+        stq_p(zmmh+8,  env->xmm_regs[i].ZMM_Q(5));
                   ^

ERROR: spaces required around that '+' (ctx:VxV)
#216: FILE: target/i386/xsave_helper.c:52:
+        stq_p(zmmh+16, env->xmm_regs[i].ZMM_Q(6));
                   ^

ERROR: spaces required around that '+' (ctx:VxV)
#217: FILE: target/i386/xsave_helper.c:53:
+        stq_p(zmmh+24, env->xmm_regs[i].ZMM_Q(7));
                   ^

ERROR: spaces required around that '+' (ctx:VxV)
#263: FILE: target/i386/xsave_helper.c:99:
+        env->xmm_regs[i].ZMM_Q(1) = ldq_p(xmm+8);
                                              ^

ERROR: spaces required around that '+' (ctx:VxV)
#265: FILE: target/i386/xsave_helper.c:101:
+        env->xmm_regs[i].ZMM_Q(3) = ldq_p(ymmh+8);
                                               ^

ERROR: spaces required around that '+' (ctx:VxV)
#267: FILE: target/i386/xsave_helper.c:103:
+        env->xmm_regs[i].ZMM_Q(5) = ldq_p(zmmh+8);
                                               ^

ERROR: spaces required around that '+' (ctx:VxV)
#268: FILE: target/i386/xsave_helper.c:104:
+        env->xmm_regs[i].ZMM_Q(6) = ldq_p(zmmh+16);
                                               ^

ERROR: spaces required around that '+' (ctx:VxV)
#269: FILE: target/i386/xsave_helper.c:105:
+        env->xmm_regs[i].ZMM_Q(7) = ldq_p(zmmh+24);
                                               ^

total: 10 errors, 0 warnings, 242 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden