[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 04/10] migration: let MigrationState be a qde
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH v6 04/10] migration: let MigrationState be a qdev |
Date: |
Tue, 27 Jun 2017 11:59:30 -0300 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Tue, Jun 27, 2017 at 12:10:13PM +0800, Peter Xu wrote:
> Let the old man "MigrationState" join the object family. Direct benefit
> is that we can start to use all the property features derived from
> current QDev, like: HW_COMPAT_* bits, command line setup for migration
> parameters (so will never need to set them up each time using HMP/QMP,
> this is really, really attractive for test writters), etc.
>
> I see no reason to disallow this happen yet. So let's start from this
> one, to see whether it would be anything good.
>
> Now we init the MigrationState struct statically in main() to make sure
> it's initialized after global properties are applied, since we'll use
> them during creation of the object.
>
> No functional change at all.
>
> Reviewed-by: Juan Quintela <address@hidden>
> Signed-off-by: Peter Xu <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
--
Eduardo
- Re: [Qemu-devel] [PATCH v6 01/10] machine: export register_compat_prop(), (continued)
[Qemu-devel] [PATCH v6 02/10] accel: introduce AccelClass.global_props, Peter Xu, 2017/06/27
[Qemu-devel] [PATCH v6 03/10] vl: clean up global property registerations, Peter Xu, 2017/06/27
[Qemu-devel] [PATCH v6 04/10] migration: let MigrationState be a qdev, Peter Xu, 2017/06/27
- Re: [Qemu-devel] [PATCH v6 04/10] migration: let MigrationState be a qdev, Eduardo Habkost, 2017/06/27
- Re: [Qemu-devel] [PATCH v6 04/10] migration: let MigrationState be a qdev,
Eduardo Habkost <=
- Re: [Qemu-devel] [PATCH v6 04/10] migration: let MigrationState be a qdev, Max Reitz, 2017/06/29
- Re: [Qemu-devel] [PATCH v6 04/10] migration: let MigrationState be a qdev, Peter Xu, 2017/06/29
- Re: [Qemu-devel] [PATCH v6 04/10] migration: let MigrationState be a qdev, Peter Xu, 2017/06/30
- Re: [Qemu-devel] [PATCH v6 04/10] migration: let MigrationState be a qdev, Max Reitz, 2017/06/30
- Re: [Qemu-devel] [PATCH v6 04/10] migration: let MigrationState be a qdev, Eric Blake, 2017/06/30
- Re: [Qemu-devel] [PATCH v6 04/10] migration: let MigrationState be a qdev, Max Reitz, 2017/06/30
[Qemu-devel] [PATCH v6 05/10] migration: move global_state.optional out, Peter Xu, 2017/06/27
[Qemu-devel] [PATCH v6 06/10] migration: move only_migratable to MigrationState, Peter Xu, 2017/06/27