[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 16/19] block: protect modification of dirty bitm
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 16/19] block: protect modification of dirty bitmaps with a mutex |
Date: |
Tue, 27 Jun 2017 17:42:49 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 |
On 27/06/2017 17:32, Vladimir Sementsov-Ogievskiy wrote:
>>>>
>>>>
>>>> - we protect inserting into list from other threads, but what prevent
>>>> creating bitmap with the same name from other thread after
>>>> bdrv_find_dirty_bitmap() and before bdrv_dirty_bitmaps_lock() ?
>>> It's like a read-write lock.
>>
>> Ok, finally I understand (not all, but the main idea=), sorry for
>> annoying.
>
> Is there any example of accessing dirty bitmaps for read not under BQL
> but only under dirty bitmap lock?
Yes, search for bdrv_dirty_bitmap_lock...unlock in block/mirror.c.
There is also block/backup.c, which operates on a frozen bitmap.
Paolo
- Re: [Qemu-devel] [PATCH 16/19] block: protect modification of dirty bitmaps with a mutex, (continued)
- Re: [Qemu-devel] [PATCH 16/19] block: protect modification of dirty bitmaps with a mutex, Vladimir Sementsov-Ogievskiy, 2017/06/27
- Re: [Qemu-devel] [PATCH 16/19] block: protect modification of dirty bitmaps with a mutex, Paolo Bonzini, 2017/06/27
- Re: [Qemu-devel] [PATCH 16/19] block: protect modification of dirty bitmaps with a mutex, Vladimir Sementsov-Ogievskiy, 2017/06/27
- Re: [Qemu-devel] [PATCH 16/19] block: protect modification of dirty bitmaps with a mutex, Paolo Bonzini, 2017/06/27
- Re: [Qemu-devel] [PATCH 16/19] block: protect modification of dirty bitmaps with a mutex, Vladimir Sementsov-Ogievskiy, 2017/06/27
- Re: [Qemu-devel] [PATCH 16/19] block: protect modification of dirty bitmaps with a mutex, Paolo Bonzini, 2017/06/27
- Re: [Qemu-devel] [PATCH 16/19] block: protect modification of dirty bitmaps with a mutex, Vladimir Sementsov-Ogievskiy, 2017/06/27
- Re: [Qemu-devel] [PATCH 16/19] block: protect modification of dirty bitmaps with a mutex, Paolo Bonzini, 2017/06/27
- Re: [Qemu-devel] [PATCH 16/19] block: protect modification of dirty bitmaps with a mutex, Vladimir Sementsov-Ogievskiy, 2017/06/27
- Re: [Qemu-devel] [PATCH 16/19] block: protect modification of dirty bitmaps with a mutex, Vladimir Sementsov-Ogievskiy, 2017/06/27
- Re: [Qemu-devel] [PATCH 16/19] block: protect modification of dirty bitmaps with a mutex,
Paolo Bonzini <=
[Qemu-devel] [PATCH 15/19] migration/block: reset dirty bitmap before reading, Paolo Bonzini, 2017/06/05
[Qemu-devel] [PATCH 18/19] block: split BlockAcctStats creation and setup, Paolo Bonzini, 2017/06/05
[Qemu-devel] [PATCH 19/19] block: make accounting thread-safe, Paolo Bonzini, 2017/06/05
Re: [Qemu-devel] [PATCH v4 00/19] Block layer thread safety, part 1, no-reply, 2017/06/05
Re: [Qemu-devel] [PATCH v4 00/19] Block layer thread safety, part 1, Fam Zheng, 2017/06/06