Re: [Qemu-devel] [RFC PATCH 01/14] pc-bios/s390-ccw: Add the libc from the SLOF firmware

[David Hildenbrand]

On 27.06.2017 13:48, Thomas Huth wrote:
> To be able to use some more advanced libc functions in the s390-ccw
> firmware, like printf() and malloc(), we need a better libc here.
> This patch adds the C library from the SLOF firmware (taken from
> the SLOF commit ID 62674aabe20612a9786fa03e87cf6916ba97a99a). The
> files are copied without modifications here and will be adapted for
> the s390-ccw firmware by the next patch. I just removed the getopt()
> and scanf()-like functions from the libc since we likely do not need
> them in the s390-ccw firmware.
> 

We have SLOF as a git submodule in roms/SLOF.

I wonder if there would a way to avoid duplicating files.

E.g. build s390x-ccw.img only if roms/SLOF is checked out and link/copy
the right folder.

Then, also the question regarding coding style is gone.

Would something like that work?


-- 

Thanks,

David