qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] qga:windows os lost ip when network nic change


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH] qga:windows os lost ip when network nic change pic order
Date: Tue, 27 Jun 2017 16:14:57 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0

On 06/24/2017 12:39 AM, address@hidden wrote:
> From: "yin.zuowei" <address@hidden>
> 
> Signed-off-by: yin.zuowei <address@hidden>
> 
> bug description: In the windows virtual machine, if there are multiple 
> network cards, the hypothesis is that A/B/C is equipped with a different IP 
> address. Once you delete a B card in the middle and restart the virtual 
> machine, you will find that the A/C of the network card IP has been confused, 
> and the IP of the C network card has become the address of B, and the service 
> has been interrupted. So we did a IP recovery function in qga.This is a 
> serious problem that can lead to business disruption. If you have a better 
> plan, we would like to offer it to you.
> ---
>  qga/restoreIp.cpp | 1848 
> +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 1848 insertions(+)
>  create mode 100755 qga/restoreIp.cpp
> 
> diff --git a/qga/restoreIp.cpp b/qga/restoreIp.cpp
> new file mode 100755
> index 0000000..2382136
> --- /dev/null
> +++ b/qga/restoreIp.cpp
> @@ -0,0 +1,1848 @@
> +// restoreIp.cpp : �������̨Ӧ�ó������ڵ㡣

Your mail header said:

> Content-Type: text/plain; charset=yes

which looks like a bug with your git settings (typically, it should be
charset=UTF-8).  Much of the message didn't render for me (not sure if
it lack of fonts on my end, or if it really was garbled en route rather
than being valid UTF-8 round-trip).  But we much prefer /* */ comments
over // (even in C++ code), and prefer those comments to be in English.

> +//#pragma comment(lib,"iphlpapi.lib")

Dead code?

> +
> +/*Ҫע�⣬����unicode�� memcpy����������Ҫʹ��XXX_LEN * sizeof(TCHAR)*/

More encoding awkwardness.

It's hard to review the patch when the content is difficult to read.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]