Re: [Qemu-devel] [RFC v1 2/3] util/qemu-error: Add a warning_report() function

[Daniel P. Berrange]

On Tue, Jun 27, 2017 at 01:45:45PM -0700, Alistair Francis wrote:
> Add a functino which can be used similarly to error_report() execpt to
> inform the users about warnings instead of errors.
> 
> The warning print does not include the timestamp and instead will
> preface the messages with a 'warning: '.

Not including the timestamp is a bug IMHO. If I've turned on timestamps,
I expect all messages to have the timestamp.

I'm not particularly convinced by adding the 'warning: ' prefix either,
particularly given the scenario you are using this in, is not actually
a warning - its just a informative message.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|