[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/5] virtio-pci: use ioeventfd even when KVM is
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 1/5] virtio-pci: use ioeventfd even when KVM is disabled |
Date: |
Wed, 28 Jun 2017 13:17:30 +0100 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Tue, Jun 27, 2017 at 01:07:35PM +0200, Kevin Wolf wrote:
> Am 27.06.2017 um 10:43 hat Fam Zheng geschrieben:
> > On Thu, 06/15 17:38, Stefan Hajnoczi wrote:
> > > Old kvm.ko versions only supported a tiny number of ioeventfds so
> > > virtio-pci avoids ioeventfds when kvm_has_many_ioeventfds() returns 0.
> > >
> > > Do not check kvm_has_many_ioeventfds() when KVM is disabled since it
> > > always returns 0. Since commit 8c56c1a592b5092d91da8d8943c17777d6462a6f
> > > ("memory: emulate ioeventfd") it has been possible to use ioeventfds in
> > > qtest or TCG mode.
> > >
> > > This patch makes -device virtio-blk-pci,iothread=iothread0 work even
> > > when KVM is disabled.
> > >
> > > I have tested that virtio-blk-pci works under TCG both with and without
> > > iothread.
> > >
> > > Cc: Michael S. Tsirkin <address@hidden>
> > > Signed-off-by: Stefan Hajnoczi <address@hidden>
> >
> > This one was dropped out from Kevin's pull request but the iotest case
> > update on 068 which depends on it is merged. Now the test fails for
> > me:
>
> Whoops, sorry about that. Anyway, I think if we can, the way to fix it
> is to find out why this patch is failing qtest, and merge a fixed v2,
> rather than reverting the test cases.
>
> Stefan, can you reproduce the failure?
I will merge this patch via my tree and send a pull request today.
The purpose of this patch is to make -device virtio-blk-pci,iothread=ID
work under TCG/qtest. This is necessary because qemu-iotests isn't
allowed to depend on KVM.
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH 0/5] qemu-iotests: test savevm/loadvm iothread (and make it work!), Stefan Hajnoczi, 2017/06/15
- [Qemu-devel] [PATCH 2/5] migration: hold AioContext lock for loadvm qemu_fclose(), Stefan Hajnoczi, 2017/06/15
- [Qemu-devel] [PATCH 3/5] qemu-iotests: 068: extract _qemu() function, Stefan Hajnoczi, 2017/06/15
- Re: [Qemu-devel] [PATCH 3/5] qemu-iotests: 068: extract _qemu() function, Kevin Wolf, 2017/06/19
- Re: [Qemu-devel] [PATCH 3/5] qemu-iotests: 068: extract _qemu() function, Eric Blake, 2017/06/27
- Re: [Qemu-devel] [PATCH 3/5] qemu-iotests: 068: extract _qemu() function, Kevin Wolf, 2017/06/28
- Re: [Qemu-devel] [PATCH 3/5] qemu-iotests: 068: extract _qemu() function, Eric Blake, 2017/06/28
- Re: [Qemu-devel] [PATCH 3/5] qemu-iotests: 068: extract _qemu() function, Kevin Wolf, 2017/06/28