[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/7] qdev: Introduce DEFINE_PROP_LINK
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 4/7] qdev: Introduce DEFINE_PROP_LINK |
Date: |
Wed, 28 Jun 2017 16:06:52 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 |
On 28/06/2017 16:02, Fam Zheng wrote:
>>> It's implemented by creating a wrapper property that basically forwards
>>> operations to a QOM "link-FOO" property, which handles the check
>>> callback and flags. The feature that is missing from QOM is the dynamic
>>> child pointer which is done in the added code with the usual "offset"
>>> approach.
>> Would it be possible to add a ".create" field to PropertyInfo? Then
>> there's no need to introduce the wrapper.
> QOM setter/getter want a LinkProperty opaque pointer, but qdev uses a Property
> pointer. I don't see a way to adapt that with .create(). Can you elaborate?
The .create() callback would call object_property_add_link directly.
There would be no change in the properties at the QOM level, but the
PropertyInfo lets "info qtree" show the property.
Paolo
[Qemu-devel] [PATCH 5/7] virtio-blk: Use DEFINE_PROP_LINK, Fam Zheng, 2017/06/28
[Qemu-devel] [PATCH 6/7] virtio-scsi: Use DEFINE_PROP_LINK, Fam Zheng, 2017/06/28
[Qemu-devel] [PATCH 7/7] virtio-rng: Use DEFINE_PROP_LINK, Fam Zheng, 2017/06/28