[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 10/10] migration: hmp: dump globals
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH v6 10/10] migration: hmp: dump globals |
Date: |
Wed, 28 Jun 2017 14:12:44 -0300 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Tue, Jun 27, 2017 at 12:10:19PM +0800, Peter Xu wrote:
> Now we have some globals that can be configured for migration. Dump them
> in HMP info migration for better debugging.
>
> (we can also use this to monitor whether COMPAT fields are applied
> correctly on compatible machines)
>
> Reviewed-by: Juan Quintela <address@hidden>
> Signed-off-by: Peter Xu <address@hidden>
[...]
> +void migration_global_dump(Monitor *mon)
> +{
> + MigrationState *ms = migrate_get_current();
> +
> + monitor_printf(mon, "globals: store-global-state=%d, only_migratable=%d,
> "
> + "send-configuration=%d, send-section-footer=%d\n",
> + ms->store_global_state, ms->only_migratable,
> + ms->send_configuration, ms->send_section_footer);
I wouldn't call them "globals", I would just call them "properties" (or
maybe just "settings"). They happen to be affected by global properties
if the accel/machine/user sets them, but they are just plain old QOM
properties.
> +}
> +
> static Property migration_properties[] = {
> DEFINE_PROP_BOOL("store-global-state", MigrationState,
> store_global_state, true),
> --
> 2.7.4
>
--
Eduardo
- Re: [Qemu-devel] [PATCH v6 07/10] migration: move skip_configuration out, (continued)
[Qemu-devel] [PATCH v6 10/10] migration: hmp: dump globals, Peter Xu, 2017/06/27
- Re: [Qemu-devel] [PATCH v6 10/10] migration: hmp: dump globals,
Eduardo Habkost <=
[Qemu-devel] [PATCH v6 11/10] migration: add comment for TYPE_MIGRATE, Peter Xu, 2017/06/28