[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 06/26] target: [tcg, i386] Port to DisasConte
From: |
Emilio G. Cota |
Subject: |
Re: [Qemu-devel] [PATCH v9 06/26] target: [tcg, i386] Port to DisasContextBase |
Date: |
Thu, 29 Jun 2017 17:50:28 -0400 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Wed, Jun 28, 2017 at 14:23:07 +0300, Lluís Vilanova wrote:
> Emilio G Cota writes:
>
> > On Sun, Jun 25, 2017 at 12:07:57 +0300, Lluís Vilanova wrote:
> >> Incrementally paves the way towards using the generic instruction
> >> translation
> >> loop.
> >>
> >> Signed-off-by: Lluís Vilanova <address@hidden>
>
> > Just a minor nit: the commit titles are a little strange to me.
> > I'd rather do: "target/arch: foo" than "target: [tcg, arch]: foo" --
> > it's less characters ("tcg" is redundant) and seems more in line with
> > qemu's idioms.
>
> Is tcg redundant? I thought it was necessary for differentiating it from the
> kvm
> target-specific parts.
In most cases it is redundant -- anyway my point is that "targer/foo"
will be enough to get the right eyes on the patch.
Cheers,
E.
- Re: [Qemu-devel] [PATCH v9 04/26] target: [tcg] Add generic translation framework, (continued)
- [Qemu-devel] [PATCH v9 07/26] target: [tcg, i386] Refactor init_disas_context, Lluís Vilanova, 2017/06/25
- [Qemu-devel] [PATCH v9 08/26] target: [tcg, i386] Refactor init_globals, Lluís Vilanova, 2017/06/25
- [Qemu-devel] [PATCH v9 09/26] target: [tcg, i386] Refactor insn_start, Lluís Vilanova, 2017/06/25
- [Qemu-devel] [PATCH v9 10/26] target: [tcg, i386] Refactor breakpoint_check, Lluís Vilanova, 2017/06/25
- [Qemu-devel] [PATCH v9 11/26] target: [tcg, i386] Refactor disas_insn, Lluís Vilanova, 2017/06/25
- [Qemu-devel] [PATCH v9 12/26] target: [tcg,i386] Refactor tb_stop, Lluís Vilanova, 2017/06/25
- [Qemu-devel] [PATCH v9 13/26] target: [tcg, i386] Refactor disas_flags, Lluís Vilanova, 2017/06/25
- [Qemu-devel] [PATCH v9 14/26] target: [tcg, i386] Replace DISAS_* with DJ_*, Lluís Vilanova, 2017/06/25