[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 0/2] main_loop: Make main_loop_wait() return
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v3 0/2] main_loop: Make main_loop_wait() return void |
Date: |
Fri, 30 Jun 2017 12:47:44 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 |
On 27/06/2017 19:32, Peter Maydell wrote:
> This patchset removes the useless return value from
> main_loop_wait().
>
> Changes v2->v3:
> * add initial patch which removes the use of the return value
> from the version of main_loop in test-char.c -- it didn't
> really need it anyway.
> * removed unnecessary 'return;' at end of function
>
> NB: I've just also noticed that there is exactly one use in the
> tree of the argument to main_loop_wait() now which doesn't
> pass 'false' -- that is in a function in hw/display/xenfb.c
> that was added 8 years ago with a comment claiming it was
> strictly temporary ;-)
>
>
> Peter Maydell (2):
> tests/test-char.c: Don't use main_loop_wait()'s return value
> main_loop: Make main_loop_wait() return void
>
> include/qemu/main-loop.h | 2 +-
> tests/test-char.c | 6 +-----
> util/main-loop.c | 8 +-------
> 3 files changed, 3 insertions(+), 13 deletions(-)
>
Queued, thanks.
Paolo