Re: [Qemu-devel] [PATCH v11 04/29] target: [tcg] Add generic translation framework

[Richard Henderson]

On 06/28/2017 05:32 AM, Lluís Vilanova wrote:
> +    void (*init_disas_context)(DisasContextBase *db, CPUState *cpu);
> +    void (*init_globals)(DisasContextBase *db, CPUState *cpu);
> +    void (*tb_start)(DisasContextBase *db, CPUState *cpu);
> +    void (*insn_start)(DisasContextBase *db, CPUState *cpu);
> +    BreakpointCheckType (*breakpoint_check)(DisasContextBase *db, CPUState 
> *cpu,
> +                                            const CPUBreakpoint *bp);
> +    target_ulong (*translate_insn)(DisasContextBase *db, CPUState *cpu);
> +    void (*tb_stop)(DisasContextBase *db, CPUState *cpu);
> +    void (*disas_log)(const DisasContextBase *db, CPUState *cpu);

Any reason not to stuff the cpu pointer into the DisasContextBase instead of 
passing it around separately?

Otherwise,

Reviewed-by: Richard Henderson <address@hidden>


r~