qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v11 12/29] target/i386: [tcg] Refactor disas_log


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH v11 12/29] target/i386: [tcg] Refactor disas_log
Date: Sat, 1 Jul 2017 17:49:36 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0

On 06/28/2017 06:05 AM, LluĂ­s Vilanova wrote:
+#ifdef TARGET_X86_64
+    if (dc->code64)
+        disas_flags = 2;
+    else
+#endif
+        disas_flags = !dc->code32;

Even though this is code movement, missing braces.

Otherwise,

Reviewed-by: Richard Henderson <address@hidden>


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]