[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/2] target/sh4: fix fabs and optimize fneg
From: |
Bruno Haible |
Subject: |
Re: [Qemu-devel] [PATCH 0/2] target/sh4: fix fabs and optimize fneg |
Date: |
Sun, 02 Jul 2017 19:03:50 +0200 |
User-agent: |
KMail/5.1.3 (Linux/4.4.0-81-generic; KDE/5.18.0; x86_64; ; ) |
Hi Aurelien,
> This patchset should fix the bug #1701821 reported by Bruno Haible,
> which makes the gnulib testsuite to fail for single precision libm
> tests.
>
> Aurelien Jarno (2):
> target/sh4: do not check for PR bit for fabs instruction
> target/sh4: do not use a helper to implement fneg
Thanks. It fixes most of the reported issues indeed. The following tests
still fail, though:
$ ~/inst-qemu/2.9.0/bin/qemu-sh4 test-floor2
../../gltests/test-floor2.c:130: assertion 'correct_result_p (x, reference)'
failed
qemu: uncaught target signal 6 (Aborted) - core dumped
$ ~/inst-qemu/2.9.0/bin/qemu-sh4 test-round2
reference implementations disagree: round(nan(nan)) = nan(nan) or 0(0x0p+0)?
$ ~/inst-qemu/2.9.0/bin/qemu-sh4 test-roundf2
reference implementations disagree: roundf(nan(nan)) = nan(nan) or 0(0x0p+0)?
But these could also be glibc bugs in the respective functions; I cannot tell.
Bruno